Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Function support #106

Open
5 tasks done
mjg123 opened this issue Nov 27, 2017 · 5 comments
Open
5 tasks done

Spring Cloud Function support #106

mjg123 opened this issue Nov 27, 2017 · 5 comments

Comments

@mjg123
Copy link

mjg123 commented Nov 27, 2017

Try to get this ready in time for SpringOne.

  • This needs to be a separate jar
  • Need to be able to supply a FunctionInvoker from a separate jar
  • SCF support
  • Example Project
  • Blog post
@dsyer
Copy link

dsyer commented Nov 27, 2017

If you're going to be at SpringOne we should definitely talk about the best place to host fn support for Spring Cloud Function. If you need to make changes there, irrespective of where we host the adapter, please get in touch (or send PRs).

@carimura
Copy link
Member

@dsyer I'll be there Monday. Would be great to discuss. Spring is a priority integration target for us.

@mjg123 mjg123 changed the title Spring Cloud Functions support Spring Cloud Function support Nov 28, 2017
@mjg123
Copy link
Author

mjg123 commented Nov 28, 2017

Thanks @dsyer! I'll have something useable in-tree soon, then we can discuss more based on that.

@mjg123
Copy link
Author

mjg123 commented Dec 4, 2017

This is in the latest released version. See https://github.com/fnproject/fn-spring-cloud-function-example

A few of things left to do:

  • Input coercion of JSON objects is not working - we always get LinkedHashMap
  • Some configurations cause Spring to act in ways which are prohibited by our JDK9 setup (which doesn't specify --warn-on-illegal-reflection type arguments atm) Needs investigation to see what actually triggers it and whether we can fix it in a better way than just allowing all the things which Jigsaw prevents by default.
  • Errors when none of the Spring Beans is a possible function are badly handled (NPE). Better error messages is the best we can do here, though.
  • NPE when your function bean returns null
  • need to have an unused method to define the entrypoint: Move the check for a method into the MethodInvoker #113

@gu6161
Copy link

gu6161 commented May 31, 2018

Hi, i had a problem that when i test a function such as uppercase or lowercase after fn routes configured successfully, the docker container will always be built eachtime when i send a request. And the container will be destoryed when the request finished.
Compared with fn-spring-cloud-function, the original fn function ensures that the container will always exist until time out for no request comes in.
Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants