-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is there a plan to upgrade r941_prom_hac_g360+g422 model to any of latest model soon? #6547
Comments
Yes! My plan is to do two things:
If (1) is not accepted on the bioconda side we will need to build a tool to download models and / or a data manager. I'd prefer not to go that route. Does this sound reasonable to you? |
Totally. (1) is probably the better solultion. I would also avoid to deal with data manager if possible. Do you know when will the model available ? |
How big are the models? |
@bernt-matthias the latest are 310 MB in size in total. I have since realised that my plan in (1) will not work. The models in the rerio repository are distributed under the Oxford Nanopore Technologies PLC. Public License v. 1.0 which does not appear to be an Open Source license (see the discussion here). Or at least I cannot verify that it is an Open Source license. So distributing the models with the clair3 software would not work (Bioconda is for open source software). Which means, I think, that a data manager would need to be built - but could this be used on a public Galaxy server? One of the particularly concerning (for me) parts of the Oxford Nanopore Technologies PLC. Public License v. 1.0 is this: "Each Contributor hereby grants You a world-wide, royalty-free, What does "Research Purposes" mean? I know that some Galaxy servers have negotiated for the use of "Free for Academic Use" software on their servers. I have written to ONT to ask in which way these models may be re-used in a public context. |
Then (to me) a data manager seems better than inclusion in bioconda.
Yep. Sometimes a statement in the help / description was sufficient, sometime a boolean parameter where users need to agree to the license. |
The Galaxy clair3 tool currently uses r941_prom_hac_g360+g422 model and r941_prom_sup_g5014 model.
tools-iuc/tools/clair3/tool-data/model.loc.sample
Line 10 in 0ee665c
I would like to find out if the model will be upgraded to any of the model listed here https://github.com/nanoporetech/rerio/tree/master/clair3_models .
Thanks
The text was updated successfully, but these errors were encountered: