Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to exclude a specific check from being required for deployment? #321

Open
redoz opened this issue Nov 15, 2024 · 1 comment
Labels
question Further information is requested or the issue is a question

Comments

@redoz
Copy link

redoz commented Nov 15, 2024

Details

We use branch-deploy to deploy to our dev environments and part of that deployment is to run our integration test suite. This test suite creates a check in github to indicate whether it succeeded or not, and this check is required to succeed for us to merge this branch into main.

Now, branch-deploy also requires all checks to pass before running the deployment, so we have a bit of a catch 22 if the integration tests fail, we cannot re-run the deployment without touching the branch to reset the failed check, which could trigger lengthy builds due to the content in the pull request.

In theory this isn't something that should be required, the tests fail, you should fix them before trying to re-run them, but unfortunately it can happen due to the complexity of the system and the tests that a test can fail due to an issue with an external dependency.

I think in effect what I'm asking for is an inverse to required_contexts, a way to opt out of a check being required for the deployment (even though it's required in the branch protection settings of the repository).

@redoz redoz added the question Further information is requested or the issue is a question label Nov 15, 2024
@GrantBirki
Copy link
Member

👋 Hey @redoz thank you for opening this issue and sorry for the delay, I was traveling. I think your suggested approach makes a lot of sense. You are probably looking for a new feature where we have something like ignored_contexts in addition to the existing required_contexts so that certain CI checks can be disabled.

That could potentially take some time to implement. In the meantime, have you looked into the checks: "required" field? Perhaps you could make your acceptance test (for your dev env) not required and then use this branch-deploy setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested or the issue is a question
Projects
None yet
Development

No branches or pull requests

2 participants