Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information in Publishing actions in GitHub Marketplace might be wrong #35423

Open
1 of 6 tasks
jsoref opened this issue Nov 26, 2024 · 3 comments
Open
1 of 6 tasks

Information in Publishing actions in GitHub Marketplace might be wrong #35423

jsoref opened this issue Nov 26, 2024 · 3 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team

Comments

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Nov 26, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 26, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@nguyenalex836
Copy link
Contributor

@jsoref Thanks again for raising this issue! Would you mind doing us a favor, and breaking each of the concerns here into a separate issue? This should allow for a smoother, more efficient review process for our writers and SMEs ✨

This should really include advice not to have 300mb of stuff in a release (github/codeql-action currently does this and it means that anyone using the action has to wait 6 seconds for it to download).

I'm not sure this is a real requirement... At the very least, the GitHub Actions organization violates this:

I didn't search (and I can't think of a way to search for this), but I don't think I can think of any repositories that don't have workflow files.

This is apparently false. While researching an earlier point, I found one action listed on the marketplace without a root level action.yml,
enricomarino/actions https://github.com/search?q=repo%3Aenricomarino%2Factions%20path%3Aaction.yml&type=code

And, it works: https://github.com/Finastra/fds-angular/actions/runs/10681780031/job/29606154031#step:9:1 (there were other theoretical users, but I didn't find any recent workflow runs among them).

I'm not sure if this still happens. I tried creating a test action and while I tripped over some of the other items, I didn't see "Everything looks good!"

Let us know if you have any concerns with this 💛

@jsoref
Copy link
Contributor Author

jsoref commented Nov 26, 2024

Done

@nguyenalex836 nguyenalex836 removed the waiting for review Issue/PR is waiting for a writer's review label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

No branches or pull requests

2 participants