Inject match arms sorted by "truthy" value first when running add missing patterns code action

[JosephTLyons]

Currently, when running add missing patterns, for Result and Bool, "falsy" values are always injected first.

case 1 == 1 {
  False -> todo
  True -> todo
}

case Ok(1) {
  Error(_) -> todo
  Ok(_) -> todo
}

It seems like there are two groups of people here. The first group dynamically adjusts the order here based on what follows in the bodies of each arm (shorter path first), the second group always uses the same order. For the first group, no default ordering is going to work all the time, if they are always changing it depending on context, but for the second group, and for people coming from other languages, I believe many are used to the "truthy" values being first. For instance, coming from Rust, their default ordering when running the language server action is:

match Ok(1) {
    Ok(_) => todo!(),
    Err(_) => todo!(),
}

match 1 == 1 {
    true => todo!(),
    false => todo!(),
}

I think for built-in Gleam types that have a finite number of options, the language server could sort these to be "truthy" first - "hardcoded." For custom types, it could fallback to the current behavior, as the language server wouldn't have any context on how to sort those.

I find myself reordering these patterns frequently after using the actions. While preferences vary, I think a good chunk of Gleam users might come from Rust. Using Rust's output as an example sort of highlights the fact that these newer Gleam users might also be surprised by the current behavior here.

Note that there might be other built-in types that this would make sense for too, Bool and Result are just the ones I hit frequently.

[joshi-monster]

What about adding them in the same order as they are defined?

[JosephTLyons]

What about adding them in the same order as they are defined?

That would be nice!

[lpil]

Hello! I'm not sure what the goal is with this item of work. What problems would you say this solves? For the given examples I think you could just as easily argue in the other direction.