Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenesisNetworkInfo should use AddressBook, not Roster. #16643

Open
Tracked by #14706
edward-swirldslabs opened this issue Nov 18, 2024 · 0 comments · May be fixed by #16759
Open
Tracked by #14706

GenesisNetworkInfo should use AddressBook, not Roster. #16643

edward-swirldslabs opened this issue Nov 18, 2024 · 0 comments · May be fixed by #16759
Assignees

Comments

@edward-swirldslabs
Copy link
Contributor

edward-swirldslabs commented Nov 18, 2024

Background

The current code reads config.txt on genesis, constructs a genesis address book, then constructs a genesis roster from the AB, and finally constructs the GenesisNetworkInfo from the genesis roster.

if (trigger == GENESIS) {
final var config = configProvider.getConfiguration();
final var ledgerConfig = config.getConfigData(LedgerConfig.class);
final var genesisRoster = createRoster(requireNonNull(genesisAddressBook));
genesisNetworkInfo = new GenesisNetworkInfo(genesisRoster, ledgerConfig.id());
}

What should happen is that the roster is not created until just before handing the roster over to the platform. The GenesisNetworkInfo should be constructed using the genesis AddressBook.

In the node.proto in translating from AddressBook, the order of gossip endpoints should be internal ip address at index 0 and external ip address at index 1.

Acceptance Criteria

Rosters are not created until we're ready to give it to the platform.

When constructing a roster, the order of gossip endpoints is reversed. external at index 0 and internal at index 1.

Notes

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Nov 18, 2024
@mhess-swl mhess-swl self-assigned this Nov 18, 2024
@netopyr netopyr moved this from 📋 Backlog to To Do in Services Team Nov 19, 2024
@netopyr netopyr moved this from To Do to 📋 Backlog in Services Team Nov 19, 2024
@mhess-swl mhess-swl moved this from 📋 Backlog to 👷🏼‍♀️ In Progress in Services Team Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👷🏼‍♀️ In Progress
Development

Successfully merging a pull request may close this issue.

2 participants