New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generated native else branch shouldn't try to parse json #38

Open

jappeace opened this issue Apr 9, 2019 · 0 comments

jappeace commented Apr 9, 2019

In my case I had a simple connection issue, but because it attempted to parse that result I coudln't see the error.

else {
        try { res = JSON.parse(xhr.responseText); } catch (e) { onError(e); }
        if (res) onError(res);
      }

should become:

else {
       onError(xhr); // let t he user figure it out
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment