Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement options.timeout for sessions.add(options) #16

Open
gr2m opened this issue Oct 17, 2016 · 2 comments
Open

implement options.timeout for sessions.add(options) #16

gr2m opened this issue Oct 17, 2016 · 2 comments
Assignees
@vkai

Comments

@gr2m
Copy link
Member

gr2m commented Oct 17, 2016 •
edited
Loading

follow up for #14

Currently the timeout is hardcoded to 14 days. Make it a default instead and allow to overwrite via options.timeout. Amend README accordingly
@gr2m gr2m mentioned this issue Oct 17, 2016
Closed
14 tasks
@vkai vkai self-assigned this Nov 28, 2016
@gr2m
Copy link
Member Author

gr2m commented Jan 26, 2017

hey @vkai do you still want to look into this? Happy to give you some guidance.

For now we changed the hardcoded time from 14 days to 100 years, basically no timeout at all :) The timeout does not get renewed, it’s 14 days from the sign in, not the last activity, so people kept running into trouble and where confused why they were signed out from their accounts.

gr2m added a commit that referenced this issue Jan 26, 2017
@gr2m
fix: remove session timeout
b4f2946 
see #16 (comment)
@vkai
Copy link
Contributor

vkai commented Feb 14, 2017

@gr2m sorry for the late reply. I'm opening a PR for this soon. Please take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkai vkai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gr2m @vkai