Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Admiral generates ServiceEntry only with cluster.local suffix #103

Open
Ultrafenrir opened this issue May 15, 2020 · 1 comment
Open

[BUG] Admiral generates ServiceEntry only with cluster.local suffix #103

Ultrafenrir opened this issue May 15, 2020 · 1 comment
Labels
bug Something isn't working needs design review
Milestone
Nebulous Future

Comments

@Ultrafenrir
Copy link

Ultrafenrir commented May 15, 2020 •
edited
Loading

Describe the bug
We have some amount of self-hosted clusters that has unique name like test-env dev-env etc.
When admiral creates ServiceEntry it does not respect cluster name and every time in endpoints section i got some.service.svc.cluster.local instead of some.service.svc.your-cluster-name

Steps To Reproduce
Deploy admiral in cluster with unique name in terms of dns resolution

Expected behavior
Make admiral understand which name should be used, or provide some flag to specify it in admiral runtime
@Ultrafenrir Ultrafenrir added the bug Something isn't working label May 15, 2020
@aattuluri
Copy link
Contributor

aattuluri commented May 16, 2020 •
edited
Loading

@Ultrafenrir This is where its hardcoded

admiral/admiral/pkg/controller/common/common.go

Line 22 in 70af3fb

DotLocalDomainSuffix = ".svc.cluster.local"
, it would be great if you can send a PR, should be a simple change to https://github.com/istio-ecosystem/admiral/blob/master/admiral/cmd/admiral/cmd/root.go if its static for all clusters being monitored by admiral (I guess thats what you are asking for)

@aattuluri aattuluri added this to the v1.1 milestone Sep 2, 2020
@aattuluri aattuluri modified the milestones: v1.1, Nebulous Future Sep 2, 2020
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
MESH-1709 support bluegreen rollout preview (istio-ecosystem#103)
7d6991e 
* Fix meshPort nil for canary rollout without weights

Signed-off-by: nbn01 <[email protected]>
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
MESH-1787 Add debug logging for events and generation (istio-ecosyste…
93391ee 
…m#104)

* MESH-1026 - Trigger pipeline

* Revert "MESH-1709 support bluegreen rollout preview (istio-ecosystem#103)"

This reverts commit 7d6991e.

* Revert "MESH-1709 support bluegreen rollout preview (istio-ecosystem#101)"

This reverts commit acca3f7.

* MESH-1787 - Undo preview endpoint generation and add informer logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs design review
Projects
None yet
Milestone
Nebulous Future
Development

No branches or pull requests
2 participants
@Ultrafenrir @aattuluri