Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skill.json can contain stale examplePhrases & keywords #96

Open
3 tasks
chrisjoj opened this issue Oct 30, 2019 · 1 comment
Open
3 tasks

skill.json can contain stale examplePhrases & keywords #96

chrisjoj opened this issue Oct 30, 2019 · 1 comment
Assignees
Labels
Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. Bug
Milestone

Comments

@chrisjoj
Copy link

I'm submitting a...

  • [x ] Bug report
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Expected Behavior

When the examplePhrases or keywords in project.js are changed, the changes should be mirrored in the generated platforms/alexaSkill/skill.json.

Current Behavior

If the number of entries in project.js is reduced, stale entries can be left in the skill.json.
I have found this issue with examplePhrases and keywords, but may affect other information that is in arrays.

Steps to reproduce

  • Create new Jovo project
  • Add the following to project.js
    alexaSkill: { nlu: 'alexa', manifest: { publishingInformation: { locales: { 'en-US': { summary: "Test Jovo Project 1", examplePhrases: [ "Example 1", "Example 2", "Example 3" ], } } } } },
  • run jovo build
  • skill.json will be generated with 3 examplePhrases. (Example 1, Example 2, Example 3)
  • edit project.js. Change to:
    alexaSkill: { nlu: 'alexa', manifest: { publishingInformation: { locales: { 'en-US': { summary: "Test Jovo Project 1", examplePhrases: [ "Example 4" ], } } } } },
  • run jovo build
  • skill.json will still contain 3 entries. (Example 4, Example 2, Example 3)

Workaround

Current workaround is to delete platforms/ folder before running jovo build

Error log

No error is generated

Your Environment

  • Jovo CLI version used: 2.2.12
  • Operating System: Ubuntu 19.04
@rubenaeg
Copy link
Contributor

This is still a bug and we'll work on fixing this. As a workaround, try jovo build --clean. This will automatically delete the platforms/alexaSkill/ folder before building again.

@rubenaeg rubenaeg added the Bug label Oct 16, 2020
@rubenaeg rubenaeg added this to the v4 milestone Feb 10, 2021
@rubenaeg rubenaeg added the Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. label Feb 12, 2021
@rubenaeg rubenaeg self-assigned this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. Bug
Projects
None yet
Development

No branches or pull requests

2 participants