-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to github.com/ko-build #791
Comments
Thanks for putting this together, Jason. The Go releases section is little unclear. Are you saying that the v0.12 release will have to be done BEFORE the repo is moved or after... because this is all just go mod magic anyway and we can do this transparently under Also, the lack of redirects on image pull requests is disappointing but kind of makes sense. Do we have a feel for the volume of unique pull sources we see on daily bases? It would be good to capture some metrics around this to understand the success rate of the image migration. |
Good question. When the repo is moved, it will still have the Go module name We can cut v0.12 any time, up to today even, with that notice that it will be moved in the future. I'd like to do this release first because I don't want the
The image doesn't get that much usage, honestly. https://github.com/google/ko/pkgs/container/ko indicates it's been downloaded 3.7k times since it was added in December (#528), which is 15 pulls/day on average. You can see per-version pull rates at https://github.com/google/ko/pkgs/container/ko/versions -- clicking back through the last few pages I don't see any that got more than ~150 pulls. |
Thanks, +1 on the version we cut in the new repo not having any functional changes. Keeps things clean. On image pull metrics, I guess the daily doesn't mean much as some use cases may not be pulling as frequently or use caching which further reduces the cadence. Still, there isn't much we can do here so giving ample of notice (which we do) and assisting people with pointers to the new image when ready, is the best we can do. |
For folks watching this, this broke certain usages of This only broke users who relied on the implicit default You can update to use this commit: - uses: imjasonh/setup-ko
+ uses: imjasonh/setup-ko@ace48d793556083a76f1e3e6068850c1f4a369aa or just |
I've enable public packages on the repo level which enabled us to make the ko package public. Let me know @imjasonh if you see any more issues with this |
This issue is stale because it has been open for 90 days with no |
Just an update: most of the items remaining are waiting on the outcome of ko's proposal as a CNCF sandbox project, and making myself and any other potential non-Google contributors org owners so we can carry out the remaining items. When (if) CNCF accepts the project we'll also donate the ko.build domain, which I currently personally own, and as such don't feel comfortable making it a load-bearing part of ko's infrastructure until its bus factor is a little higher. tl;dr: remaining items currently blocked on CNCF Sandbox decision. 🤞 |
https://opensource.googleblog.com/2022/10/ko-applies-to-become-a-cncf-sandbox-project.html => => => I don't see a currently open Sandbox application anywhere, I think there may be a gap there? |
Thanks @BenTheElder that does indeed seem like a gap. 🙃 @mchmarny Did you open a Sandbox application through the sandbox repo after toc#945 was closed? I'll start one now and link it here. edit: cncf/sandbox#17 Thanks again Ben! |
Just an update: https://github.com/imjasonh/setup-ko has moved to the The last two remaining items at this point are to move the terraform provider, and to update the importpath. I hope to move the terraform provider today, and the importpath possibly next week. |
An incomplete list of steps, more or less in order:
ko.build
vanity importpath redirect using<meta>
tagko.build
#1025ghcr.io/google/ko
image name change#ko-project
to#ko-build
(ref)setup-ko
to fetch released binaries from https://github.com/ko-build/ko/releases andgo install ko.build@main
cut v0.6not needed yetimjasonh/setup-ko
cc @mchmarny
If anybody thinks of anything that's missing, please let us know!
The text was updated successfully, but these errors were encountered: