Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let putting SBOMs in a different repository #819

Closed
developer-guy opened this issue Sep 12, 2022 · 4 comments · Fixed by #821
Closed

let putting SBOMs in a different repository #819

developer-guy opened this issue Sep 12, 2022 · 4 comments · Fixed by #821
Assignees

Comments

@developer-guy
Copy link
Collaborator

We can enable putting SBOMs in a different repository by creating another environment variable or a new configuration option.

# via environment variable
SBOM_REPOSITORY=<repo> ko build ..

# via the configuration file
.ko.yaml:
sbomRepository: <repo> 

cc: @Dentrax

🗣 Based on the talk: https://kubernetes.slack.com/archives/C032MM2CH7X/p1662936574448189
🧵 Cross-ref: kyverno/kyverno#4592

@developer-guy
Copy link
Collaborator Author

we are willing to do this ☝️

@imjasonh
Copy link
Member

I assume we'll want to push other non-SBOM things as attachments too (#357, #679), so we should come up with a name that reflects that better than SBOM_REPOSITORY. But otherwise this should be fairly straightforward, and we can start writing code and figure out the name later.

Prior art: COSIGN_REPOSITORY

@developer-guy
Copy link
Collaborator Author

developer-guy commented Sep 12, 2022

Here are the questions:

  • What do you suggest for naming? Should I go with COSIGN_REPOSITORY?

  • Should we make it configurable via the configuration file .ko.yaml or will it only be supported through an environment variable?

@imjasonh
Copy link
Member

  • What do you suggest for naming? Should I go with COSIGN_REPOSITORY?

COSIGN_REPOSITORY doesn't make sense if the user isn't aware of what cosign is.

ATTACHMENT_REPOSITORY maybe? AUX_REPOSITORY?

We could also lean in to SBOM_REPOSITORY for now, and just know that we'll end up having separate SIGNATURE_REPOSITORY, ATTESTATION_REPOSITORY, etc, env vars in the future, with some overriding XXX_REPOSITORY env var that we can name later when we're (presumably) smarter.

  • Should we make it configurable via the configuration file .ko.yaml or will it only be supported through an environment variable?

Let's start with an env var, and promote it to a config option once we have the code in place (and a name 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants