Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension needs to be updated for New Boards Hub ⚠️ #21

Open
danhellem opened this issue Aug 8, 2023 · 3 comments · Fixed by #22
Open

Extension needs to be updated for New Boards Hub ⚠️ #21

danhellem opened this issue Aug 8, 2023 · 3 comments · Fixed by #22
Assignees

Comments

@danhellem
Copy link

danhellem commented Aug 8, 2023

Hello,

I am from the Azure Boards team. Your extension has been identified as needing to be updated so that it works properly in the New Boards hub. Right now the "Change state" is showing up twice. See my notes below on how to solve this.

@danhellem
Copy link
Author

Hi,

Providing results of investigation.
Problem consists of 2 parts.

  1. First one is - wrong registration name.

We need to register new contribution and can do it via ".register(contributionName, contributionMethod)" method.
In documentation - we have example when we should send short name (aka relative name) to register method.

1

(https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-action?view=azure-devops#your-javascript )

When OWP tries to execute the code of a contribution, it tries to find the registered contribution in two ways.

by full name "v-alekseia.delivery-work-item-deletion-control.myAction"
by short name "myAction"
So it executes 2-3 times and successfully find it.
Code, responsible for execution by short name (placed in Controls.js):

2

When NWP tries to execute the code of a contribution, it only tries to find the contribution only in one way

by full name "v-alekseia.delivery-work-item-deletion-control.myAction"
I didn't find any code, responsible for cut full names.
So, that's why it doesn't execute contribution method registered with short name.

Besides that, additional point - looks like it's better to use "VSS.getContributionId()" method - to get contribution name before registering.

  1. Second issue is async execution.
    We have two method that needs to be executed

.init()
.register()
In documentation we have example which provide method execution in common sync way
(https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-action?view=azure-devops#your-javascript )

3

But inside "init" we have async operation tasks - initial handshake and only after initial handshake - continue initialization.

4

So it looks like that we need to await init method before registering some contribution - to be sure that VSS inited.

@konradsikorski
Copy link
Owner

Hi,
Thank you for feedback. I have fixed the double "Change statue" entry in context menu. The problem was with the contribution targets which new Board stooped supporting.

I have still one problem with the new board, maybe you can help me. For Query Results the "change state" option is showing as before in context menu in first section
image

but for Backlog the "Change state" is shown in last section :(
image

I am using the "modify" as groupId for my context menu option.

@konradsikorski
Copy link
Owner

@danhellem can you help me with that issue. What values the "groupId" may have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants