Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS: Validate that the pod's index in the topology ungater falls within the expected range #3651

Open
1 task
PBundyra opened this issue Nov 26, 2024 · 2 comments · May be fixed by #3666
Open
1 task

TAS: Validate that the pod's index in the topology ungater falls within the expected range #3651

PBundyra opened this issue Nov 26, 2024 · 2 comments · May be fixed by #3666
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

What would you like to be added:
Add new or refactor existing functions to validate if the the pod index in topology ungater is within [0, maxIndex] range. This is the follow-up to this comment

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Code change

The artifacts should be linked in subsequent comments.

@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 26, 2024

cc @mbobrovskyi
maybe we could have a helper function like ReadUIntFromLabelWithMax(pod, labelKey, maxValue) so that other places can use it too.

@mbobrovskyi
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants