-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] backport search functionality from evince #238
Comments
Congrats, this needs a complete rewrite of the the search function which isn't done in 5 min :P |
Looks like GNOME added entirely new widgets for that, such as I can't collect bountysource bounties due to lack of a paypal account, so I am not going to be diverted to this by the bounty. Process would be to find all the evince commits and backport them, which could potentially be as big a job as the libunique->GtkApplication transition in Caja was. That job took me literally months. |
I took a look at it 2 years ago.
Btw. |
The way I see it, the bounty itself is not incentive enough to do the work, but it gives it a bit more visibility, which could encourage other people to add to the bounty, or another random contributor to do a drive-by pull request. If anything, it bumps the issue to the top of the notification list, so there's value in that too. |
So this shows that backporting all those GNOME commits would also require redoing the widgets to use the GNOME 2/MATE toolbars and menubars rather than GtkHeaderBars. In other words, an even bigger job than that backend work I did for Caja back in 2016. In that go-around, GNOME kept all of the UI changes to separate commits from backend changes (as there was no relation between them), but in this case they could not as new GUI widgets had to be added, and those have to match the rest of evince. Too bad git isn't capable enough to resolve all the conflicts that crop up from taking a current GNOME repo and trying to revert all the UI change commits-and even then, new code would be required to set up the UI for widgets that didn't exist in the GNOME 2 days. |
Searching is much more useful in Evince since you get all matching results with context and page number in a side panel.
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41475304-feature-request-backport-search-functionality-from-evince?utm_campaign=plugin&utm_content=tracker%2F1323318&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1323318&utm_medium=issues&utm_source=github).It’s the only reason I use Evince over Atril and it doesn’t integrate with the rest of the desktop.
The text was updated successfully, but these errors were encountered: