Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accesibility / tabbing issue #330

Open
mdaintondcc opened this issue Jan 10, 2019 · 3 comments
Open

Accesibility / tabbing issue #330

mdaintondcc opened this issue Jan 10, 2019 · 3 comments

Comments

@mdaintondcc
Copy link

Hi

I've been testing one of our sites for acccessibility and in particular how screen readers or people using a keyboard navigate. An issue that came up was that if someone tabbed to an element or link that wasn't immediately visible, the browser or screen reader would skip straight past it and on to the next visible element or link.

Looking at the .js code I noticed that you are using a default state of 'visibility:hidden' and then once the element comes in to view this changes to 'visibility:visible'. The problem with this is a browser or screen reader doesn't see that element until it has animated in and will skip past it (especially if you are tabbing quickly). However if you use 'opacity' the element is seen and you can tab to it even if not immediately in view.

I made a slight edit to my version of your code and it seems to work just as well now.

Line 370.
Changed = box.style.visibility = hidden ? 'hidden' : 'visible';
To = box.style.opacity = hidden ? '0' : '1';

Is this something you might consider updating? Would rather not fork your code;)

Cheers

@lindsayweb
Copy link

Same problem. I have clients who are legally required to have accessible web sites, so I recently switched them all over to a different animate-on-scroll library that uses opacity. Would be great if WOW would consider this update.

@TrejoCode
Copy link

Same problem. I have clients who are legally required to have accessible web sites, so I recently switched them all over to a different animate-on-scroll library that uses opacity. Would be great if WOW would consider this update.

Hi, wich library use instead?

@lindsayweb
Copy link

Same problem. I have clients who are legally required to have accessible web sites, so I recently switched them all over to a different animate-on-scroll library that uses opacity. Would be great if WOW would consider this update.

Hi, wich library use instead?

I used AOS: https://michalsnik.github.io/aos/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants