Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create features which contribute socket-factory dependencies for Google Cloud SQL #1781

Open
sdelamo opened this issue May 5, 2023 · 0 comments
Assignees

Comments

@sdelamo
Copy link
Contributor

sdelamo commented May 5, 2023

Create features for the different support databases

gcp-cloudsql-mysql
gcp-cloudsql-postgresql

A feature is a class annotated with @Singleton which implements Feature. It should be placed in starter-core. Tests should use the BuildTestVerifier API.

You can contribute a dependency by using GeneratorContext::addDependency.

Since those dependencies versions are not in the Bill of Materials (BOM), you will need to define them here:

https://github.com/micronaut-projects/micronaut-starter/blob/3.9.x/gradle/templates.versions.toml

Search for examples with lookupArtifactId about how to add a dependency which reads its version from that file .

The base of the PR should be 3.10.x

@sdelamo sdelamo moved this to In Progress in 3.10.0 Release May 5, 2023
@sdelamo sdelamo moved this from In Progress to Todo in 3.10.0 Release May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants