Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of JSON keys snake_case and camelCase in responses #187

Open
ivarprudnikov opened this issue Mar 19, 2024 · 1 comment
Open

Comments

@ivarprudnikov
Copy link
Member

Inconsistent use of JSON keys: snake_case vs camelCase

Configuration object is using snake_case and is exposed to the user. The /entries/txIds endpoint returns a list that has nextLink, see renaming logic in JSON

DECLARE_JSON_REQUIRED_FIELDS_WITH_RENAMES(
GetEntriesTransactionIds::Out, transaction_ids, "transactionIds");
DECLARE_JSON_OPTIONAL_FIELDS_WITH_RENAMES(
GetEntriesTransactionIds::Out, next_link, "nextLink");

Expected behavior
All JSON keys should use camelCase naming convention.

@achamayou
Copy link
Member

This is consistent with the current state of the spec: https://github.com/ietf-wg-scitt/draft-ietf-scitt-scrapi/blob/main/draft-ietf-scitt-scrapi.md#transparency-configuration, although the layout of the config object has changed and moved to CBOR since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants