Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyscitt needs to update to a supported CCF governance API #236

Open
achamayou opened this issue Nov 20, 2024 · 2 comments
Open

pyscitt needs to update to a supported CCF governance API #236

achamayou opened this issue Nov 20, 2024 · 2 comments

Comments

@achamayou
Copy link
Member

There is logic in

from typing import TYPE_CHECKING
and elsewhere that relies on the classic CCF governance API (i.e. pre-Azure compliance, pre-versioning).

See https://microsoft.github.io/CCF/main/governance/member_rpc_api.html for details of the governance APIs

I suggest reviewing the extent to which this dependency is necessary, and minimising the surface.

@achamayou
Copy link
Member Author

Having reviewed https://github.com/microsoft/scitt-ccf-ledger/blob/main/pyscitt/pyscitt/governance.py, I am not clear on why pyscitt is wrapping the CCF governance API and exposing that in the CLI, the value seems minimal compared to letting ledger operators use ccf_cose_sign1 directly?

@ivarprudnikov
Copy link
Member

ivarprudnikov commented Nov 21, 2024

Public API is: submit,retrieve,pretty-receipt,embed-receipt,validate,split-payload which is defined in pyscitt/pyscitt/cli/main.py
Everything else would be used for testing purposes only. We need to be able to run the functional tests at the end of the day.

  • run-dev.sh is using governance, i.e. scitt governance local_development. It is used to start the local ledger to test against when running run_functional_tests.sh
  • Both demos use governance API in the examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants