Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom COSE header decoding code #7

Open
letmaik opened this issue Nov 14, 2022 · 2 comments
Open

Remove custom COSE header decoding code #7

letmaik opened this issue Nov 14, 2022 · 2 comments
Labels
enhancement New feature or request not-ready Not ready for implementation yet
Milestone

Comments

@letmaik
Copy link
Member

letmaik commented Nov 14, 2022

The t_cose 1.x release does not support decoding of custom header parameters. This functionality however is part of the dev branch of t_cose which will become 2.x.

As we need custom parameters, we currently decode the header ourselves in app/src/cose.h. Once t_cose 2.x or a pre-release of it is out, we can upgrade and remove the custom code.

@letmaik letmaik added the enhancement New feature or request label Nov 14, 2022
@plietar
Copy link
Contributor

plietar commented Nov 15, 2022

As a side note, now that CCF vendors t_cose, if we update to CCF 3.x we'll be restricted to whatever version they are using. They might object to using a pre-release version.

(In fact I tried to build with CCF 3.x and it failed because the t_cose version they use doesn't have the EdDSA support, I need to get them to update).

@achamayou
Copy link
Member

CCF will object to using pre-releases. But it also has some code to support custom header parameters it'd rather do without, and will therefore gladly upgrade to t_cose 2.x releases, as soon as they become available.

@ivarprudnikov ivarprudnikov modified the milestones: Next version, Backlog Jan 12, 2024
@ivarprudnikov ivarprudnikov added the not-ready Not ready for implementation yet label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not-ready Not ready for implementation yet
Projects
None yet
Development

No branches or pull requests

4 participants