Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "[assembly: Parallelize(Scope = ExecutionScope.MethodLevel)]" to SDK project file #4116

Open
SetTrend opened this issue Nov 21, 2024 · 5 comments

Comments

@SetTrend
Copy link

Current Situation

Currently, when a new MS Test SDK project is being created, an additional C# file is being generated ("MSTestSettings.cs") that's bloating the file list and may accidentally be deleted when using wildcards to delete a number of tests.

Desired Situation

Please provide an SDK project property to have this setting available there and remove the additional C# file from the project template.

@Evangelink
Copy link
Member

Not sure why I didn't think of it before but that's a really good suggestion!

@nohwnd
Copy link
Member

nohwnd commented Nov 25, 2024

I second this one. The <AssemblyAttribute> msbuild item is made for this:

https://learn.microsoft.com/en-us/dotnet/standard/assembly/set-attributes-project-file

@Youssef1313 Youssef1313 self-assigned this Nov 27, 2024
@Youssef1313
Copy link
Member

@Evangelink Do you know if <AssemblyAttribute> works for F#?

@Youssef1313
Copy link
Member

Looks like it's using WriteCodeFragment MSBuild task which relies on CodeDom that doesn't support F#?

https://github.com/dotnet/runtime/blob/354ec46a63440608bda18e2203bb5538e2f8eae6/src/libraries/System.CodeDom/src/System/CodeDom/Compiler/CodeDomProvider.cs#L22-L34

@nohwnd
Copy link
Member

nohwnd commented Nov 27, 2024

Image
docs say it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants