Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense support for MSTest.Sdk properties #4118

Open
Youssef1313 opened this issue Nov 22, 2024 · 5 comments · May be fixed by dotnet/msbuild#11029
Open

IntelliSense support for MSTest.Sdk properties #4118

Youssef1313 opened this issue Nov 22, 2024 · 5 comments · May be fixed by dotnet/msbuild#11029
Assignees

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Nov 22, 2024

Currently, there doesn't seem to be any IntelliSense support in csproj. I think it's useful to have such support.

I'm seeing all MSBuild IntelliSense defined here (even for Razor).

So, we could just PR to MSBuild to add IntelliSense for MSTest.Sdk.

However, it will be a better idea if we can maintain the xsd ourselves and have it shipped inside MSTest.Sdk NuGet package. This will allow us to always have the right IntelliSense depending on the actual MSTest.Sdk version that the user is using! But I don't see a way MSBuild would allow it, which is probably Razor is on MSBuild side as well.

List of properties to have IntelliSense for:

  • UseVSTest (bool)
  • EnableMSTestRunner (bool)
  • GenerateTestingPlatformEntryPoint (bool)
  • GenerateSelfRegisteredExtensions (bool)
  • GenerateProgramFile (bool)
  • DisableTestingPlatformServerCapability (bool)
  • TestingExtensionsProfile (Default, None, or AllMicrosoft)
  • EnableMicrosoftTestingExtensionsCrashDump (bool)
  • EnableMicrosoftTestingExtensionsCodeCoverage (bool)
  • EnableMicrosoftTestingExtensionsHangDump (bool)
  • EnableMicrosoftTestingExtensionsHotReload (bool)
  • EnableMicrosoftTestingExtensionsRetry (bool)
  • EnableMicrosoftTestingExtensionsTrxReport (bool)
  • EnableAspireTesting (bool)
  • EnablePlaywright (bool)
  • IsTestingPlatformApplication (bool)
  • TestingPlatformCaptureOutput (bool)
  • TestingPlatformCommandLineArguments (string - arbitrary user value)
  • TestingPlatformDotnetTestSupport (bool)
  • TestingPlatformShowTestsFailure (bool)
@Youssef1313
Copy link
Member Author

@rainersigwald Can you advise please if there is a way to provide our own xsd? Otherwise, are you okay with updating CommonTypes.xsd in MSBuild repo?

@Evangelink
Copy link
Member

I would also consider EnableMSTestRunner (bool) and all these properties https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTest.TestAdapter/build/net/MSTest.TestAdapter.targets#L5-L8

@Youssef1313 I'll let you edit the lsit above

@rainersigwald
Copy link
Member

Unfortunately there's not currently a way to provide your own XSD--but we'd be happy to accept a PR to add these to CommonTypes.xsd.

@Youssef1313
Copy link
Member Author

@Evangelink Should we consider also the TestingPlatformBuilderHook item?

@Evangelink
Copy link
Member

@Evangelink Should we consider also the TestingPlatformBuilderHook item?

I don't think so. It's quite technical and will be used by really few people (extension authors). We have documented it in the tech doc of the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants