Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntelliSense for testing properties #11029

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 25, 2024

@Youssef1313 Youssef1313 marked this pull request as ready for review November 25, 2024 12:01
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comments:

Some details like nuget packages, extensions included in profiles... are probably better not explained here but instead linked into doc so we could better handle changes and more complex details in the future.

You are sometimes wrapping values in single quotes sometimes not. It's probably better to always do it for property name, values and package names.

src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
</xs:element>
<xs:element name="EnablePlaywright" type="msb:boolean" substitutionGroup="msb:Property">
<xs:annotation>
<xs:documentation><!-- _locID_text="EnablePlaywright" _locComment="" -->Set to true to enable end-to-end testing for modern web apps using Playwright. This adds a reference to 'Microsoft.Playwright.MSTest' NuGet package.</xs:documentation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:documentation><!-- _locID_text="EnablePlaywright" _locComment="" -->Set to true to enable end-to-end testing for modern web apps using Playwright. This adds a reference to 'Microsoft.Playwright.MSTest' NuGet package.</xs:documentation>
<xs:documentation><!-- _locID_text="EnablePlaywright" _locComment="" -->Enables end-to-end testing for modern web apps using Playwright. This adds a reference to 'Microsoft.Playwright.MSTest' NuGet package.</xs:documentation>

Maybe instead of stating the NuGet we should point to our doc so we could more easily change the defaults and add more related features in the future without having to change teh doc.

</xs:element>
<xs:element name="EnableAspireTesting" type="msb:boolean" substitutionGroup="msb:Property">
<xs:annotation>
<xs:documentation><!-- _locID_text="EnableAspireTesting" _locComment="" -->Set to true to enable the testing support for .NET Aspire application model. This adds a reference to 'Aspire.Hosting.Testing' NuGet package.</xs:documentation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:documentation><!-- _locID_text="EnableAspireTesting" _locComment="" -->Set to true to enable the testing support for .NET Aspire application model. This adds a reference to 'Aspire.Hosting.Testing' NuGet package.</xs:documentation>
<xs:documentation><!-- _locID_text="EnableAspireTesting" _locComment="" -->Enables the testing support for .NET Aspire application model. This adds a reference to 'Aspire.Hosting.Testing' NuGet package.</xs:documentation>

Maybe instead of stating the NuGet we should point to our doc so we could more easily change the defaults and add more related features in the future without having to change teh doc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if links in the tooltip will be clickable though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntelliSense support for MSTest.Sdk properties
2 participants