-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Regex to Reduce Matching Time #4160
base: main
Are you sure you want to change the base?
Conversation
@nohwnd That means we need better test coverage :) |
ofc |
I thought it would be caught by OutputFormattingIsCorrect test, but that runs only on code we have symbols for, so the line is there. So probably best to add unit test for this, once we figure out what the problem is, if that is just the system being really slow, or some input throwing the regex into a really bad state. |
Ah good shout! I've just added a test for the regex. What do you think? |
The test looks good. |
A very marginal improvement on the regex performance, but an improvement none-the-less: |
@thomhurst I haven't followed in details teh discussion. Is the PR already handling the timeout case that you reported in the issue? |
Partially fixes #4159