Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Json Schema show schema details. in CompletionItemLabel #235

Open
honhimW opened this issue Jul 1, 2024 · 2 comments · May be fixed by #243
Open

[Feature Request] Json Schema show schema details. in CompletionItemLabel #235

honhimW opened this issue Jul 1, 2024 · 2 comments · May be fixed by #243

Comments

@honhimW
Copy link

honhimW commented Jul 1, 2024

As far as I know, the current JSON worker uses the string for the label property when handling completion items, rather than the CompletionItemLabel interface. Consequently, it cannot display inline brief hints in the suggestions. What I intend to convey is that I hope there could be a configuration option to control this behavior, allowing support for setting corresponding details on JSON schemas.

export interface CompletionItem {
    label: string | CompletionItemLabel;
    // ...
}

export interface CompletionItemLabel {
    label: string;
    detail?: string;
    description?: string;
}

However, I would like to set the information in CompletionItemLabel#description or #detail to display it in the suggestions.
Because most of the time, I don’t want or need to hover over the document for this.

Sincerely looking for you reply.

@sumimakito sumimakito linked a pull request Sep 21, 2024 that will close this issue
@sumimakito
Copy link

Hello @honhimW, it's true that this useful feature is missing. I have opened a pull request to implement it.

@honhimW
Copy link
Author

honhimW commented Sep 21, 2024

@sumimakito
Wow, that's great news! Thank you so much for your work.❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants