Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not displaying completion items with empty string text labels #234588

Open
timursaurus opened this issue Nov 25, 2024 · 1 comment · May be fixed by #234589
Open

Not displaying completion items with empty string text labels #234588

timursaurus opened this issue Nov 25, 2024 · 1 comment · May be fixed by #234589
Assignees
@jrieken

Comments

@timursaurus
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.95.3
  • OS Version: Darwin arm64 23.4.0

Steps to Reproduce:

  1. TypeScript Playground
class Bug {
     ' ' = 'whitespace'
     ' p' = 'padded'
     '' = 'empty'  
}

class Repl extends Bug {
     constructor() {
          super()
          // now try to access the empty string property with brackets
          this[''] // receives 3 entries from Typescript, displays only 2

     }

}

Image

Entries from extensions/typescript-language-features/src/languageFeatures/completions.ts

[
    {
        "name": "",
        "kind": "property",
        "kindModifiers": "",
        "sortText": "11",
    },
    {
        "name": " ",
        "kind": "property",
        "kindModifiers": "",
        "sortText": "11",
    },
    {
        "name": " p",
        "kind": "property",
        "kindModifiers": "",
        "sortText": "11",
    }
]
@timursaurus timursaurus linked a pull request Nov 25, 2024 that will close this issue
Open
@timursaurus
Copy link
Author

timursaurus commented Nov 25, 2024 •
edited
Loading

Similar PR with hidden labels: #184944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure that an empty string is considered valid in completion item timursaurus/vscode
2 participants
@jrieken @timursaurus