Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport updating mkdirp to 5.2.x branch #4220

Closed
G-Rath opened this issue Mar 31, 2020 · 4 comments
Closed

Backport updating mkdirp to 5.2.x branch #4220

G-Rath opened this issue Mar 31, 2020 · 4 comments
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior

Comments

@G-Rath
Copy link

G-Rath commented Mar 31, 2020

The latest version of the svg-sprite package has mocha ^5.2.0 as a dependency, which means it's being flagged by our security auditors due to mochas extract constraint on mkdirp.

While svg-sprite does appear to be active, there's not a lot of movement currently and they're gearing up for a new major, so it's not a guarantee that they'll have the bandwidth for a patch release.

For mocha, this has been addressed in master & v6; I was wondering if it would be possible to get this update backported to the v5.2.x branch.

I'm happy to create a PR into release/5.2.x if that'd help, but am unsure of the process :)

@juergba
Copy link
Contributor

juergba commented Apr 7, 2020

@G-Rath We are not patching as far back as Mocha@5 which is almost two years old.
I'm sorry.

@juergba juergba closed this as completed Apr 7, 2020
@juergba juergba added the status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior label Apr 7, 2020
@jayaddison
Copy link

@juergba I'll try to be brief, I appreciate your time and feedback as a maintainer here.

Would it be possible to clarify the maintenance policy via the project charter?

This issue affects a project using a relatively up-to-date node engine (v10.19.0) - but for various reasons it may take time to upgrade mocha.

Versioning and maintenance are problems as old as time itself, so I understand that it's not possible to backport the fix; it could help to document what the policy is so that current and future adopters can (potentially at least) be aware of the support policy.

Thanks again!

@outsideris
Copy link
Contributor

We should make a LTS strategy, but we need more discussion in here.

@jayaddison
Copy link

Thanks @outsideris - I'll follow discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior
Projects
None yet
Development

No branches or pull requests

4 participants