Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subscribing to ontology update notification #305

Open
alexskr opened this issue Feb 5, 2024 · 14 comments
Open

Implement subscribing to ontology update notification #305

alexskr opened this issue Feb 5, 2024 · 14 comments

Comments

@alexskr
Copy link
Member

alexskr commented Feb 5, 2024

New Feature Request:
I would like to propose the addition of a ontology update notification subscription feature in the UI.

@alexskr
Copy link
Member Author

alexskr commented Feb 5, 2024

relates to ncbo/bioportal-project#291

@syphax-bouazzouni
Copy link
Contributor

By Ontology update, do you mean a new submission? if this is the case there is already the submission process notification, sent each time we process a (new) submission.

@alexskr
Copy link
Member Author

alexskr commented Feb 5, 2024

notifications about new submission would be ideal although BioPortal currently has ability to notify about PROCESSING of ontologies. This can achieve desired effect but is probably too noisy for users who wish to know when new submissions become available.

@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented Feb 5, 2024

That was what we were using in Agroportal, the Ontology admins (and us the portal admins) get emails like the one below when processed.
image

But yes one more user-friendly would be better.

@alexskr
Copy link
Member Author

alexskr commented Feb 5, 2024

this is a proposal to allow other non-admin OntoPortal users to get notified when an ontology they are interested in gets a new submission

@jvendetti
Copy link
Member

What is the label "KB1 Mx:Features" that you've assigned to this ticket?

@alexskr
Copy link
Member Author

alexskr commented Feb 5, 2024

it should be enhancement.

@jonquet
Copy link

jonquet commented Feb 6, 2024

We are targetting this in AgroPortal.
We have now a new button "Watch" in the UI, a bit like in GitHub, that allow to "subscribe" to an ontollogy.

Capture d’écran 2024-02-06 à 18 39 36

Problem: the notificaitons (including getting an email when an ontology new submission has been added) does not work when someone subscribe.
But the subscription mechanism is in place:
Here is a screenshot of "My acocunt page"

Capture d’écran 2024-02-06 à 18 40 23

This issue is track on our side, @syphax-bouazzouni might point to where.

@syphax-bouazzouni
Copy link
Contributor

This issue is track on our side, @syphax-bouazzouni might point to where.

agroportal/project-management#260 and agroportal/project-management#141

@jvendetti
Copy link
Member

I support the notion of this feature, but I think it needs to be more clearly defined.

It's hard to separate the presence of a new submission and it's processing statuses. I don't think BioPortal should broadcast notifications to subscribers about a new ontology submission, unless that submission is successfully processed. Otherwise you have scenarios where users are notified of a new submission and navigate to BioPortal, only to be presented with Error Rdf. This could be confusing and potentially a bad user experience.

Additionally, how should partial processing be handled? Do we notify subscribers of a new submission if parsing succeeds but indexing fails? Or any of the other processing steps?

@jvendetti
Copy link
Member

I'd like to point out the HRAVS ontology in BioPortal, because I think the activity there is relevant to this issue.

The HuBMAP project has a need to notify members when new versions of HRAVS become available. Since we don't offer that functionality currently in production BioPortal, they decided to use a workaround of entering a note every time a new submission is uploaded:

Screenshot 2024-02-07 at 1 51 00 PM

Members interested in new submission uploads subscribe to notes for this ontology, and receive email with content like the following when new notes are created:

A new note was added to Human Reference Atlas Value Set by hubmap.curator.

----------------------------------------------------------------------------------
Subject: Release 2.3.14

- Added 3 new value items for library preparation kit 
- Added a new value item for sequencing reagent kit 
- Added 2 new value item for preparation instrument kit 
- Added 1 new value item for oligo probe panel
----------------------------------------------------------------------------------

This HuBMAP need was the main impetus behind the 6.14.2 release, where I implemented several bugfixes in the Notes functionality.

All of this is to say that I think we have a prominent use case for this type of functionality, and perhaps they'd even be willing to give feedback on some kind of initial implementation.

@jvendetti
Copy link
Member

As an add-on to my previous comment, the HRAVS ontology is a good example of points I expressed earlier in this exchange about notifying people of new submissions before the submission is fully processed. I'm subscribed to notes for HRAVS because I was interested in monitoring how well this functionality is working. I received an email today at 1:47PM, indicating that a new release (2.3.14) is now available. However, if I navigate to BioPortal (40 minutes later), the latest submissions is simply displayed as Uploaded, with no possibility to access:

Screenshot 2024-02-07 at 2 28 26 PM

@syphax-bouazzouni
Copy link
Contributor

As an add-on to my previous comment, the HRAVS ontology is a good example of points I expressed earlier in this exchange about notifying people of new submissions before the submission is fully processed. I'm subscribed to notes for HRAVS because I was interested in monitoring how well this functionality is working. I received an email today at 1:47PM, indicating that a new release (2.3.14) is now available. However, if I navigate to BioPortal (40 minutes later), the latest submissions is simply displayed as Uploaded, with no possibility to access:

Screenshot 2024-02-07 at 2 28 26 PM

Hello, I think this is due to the cache not getting updated even if you have received an email indicating that it was parsed. The original issue was described here ncbo/bioportal-project#193, and we did a (temporary) fix here ontoportal-lirmm#416, in summary, when a submission is processed in the background it refreshes the backend cache, but not rails one, as the ncbo_cron has no way to access and refresh the rais cache.

@jvendetti
Copy link
Member

Hi - yes, it occurred to me that implementing this type of functionality would shine more of a spotlight on caching issues in BioPortal, but I chose not to get into it here. I'm not convinced that the Rails cache is always the issue. I've encountered scenarios in BioPortal where flushing the Rails cache was insufficient to show a recently processed submission, and I had to go on to flush the goo cache as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants