-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Transaction Names #13
Comments
I think this would be great as a configurable option. I'm sure some people would want to see the URL and other would want to see the route name. |
I propose a pull request according to your proposal. What do you think about? #19 |
That seems perfect. It allows for either suggestion here, as well as allowing people to create their own naming strategies. |
@neeckeloo Looks Good |
What would you do concerning console request? Should we force the use of the route name? |
I think that could be left up to the user if they wanted to create a custom transaction provider that could do something specific for a console route. You have given us great starting point and people can do their own thing, or create PR's to expand whats provided with this package. |
To manage both cases, I can perhaps propose this configuration format: return [
'newrelic' => [
'transaction_name_provider' => [
'http_request' => 'NewRelic\TransactionNameProvider\HttpRequestUrlProvider',
'console_request' => 'NewRelic\TransactionNameProvider\RouteNameProvider',
],
],
]; By default, the module would be configured with |
Wouldnt it be better to send the real URL as a name instead of the called route? If hou have dynamic routes and you want to analyse with specific paramters you cant see which parameters have a huge load time or throughput or smth. You only see the route.
Nice Module!
The text was updated successfully, but these errors were encountered: