Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN Logic #319

Open
stellarpower opened this issue Sep 3, 2024 · 0 comments
Open

NaN Logic #319

stellarpower opened this issue Sep 3, 2024 · 0 comments

Comments

@stellarpower
Copy link

https://github.com/neuromore/studio/blob/1.7.3/src/Engine/Core/Math.inl#L11

Not sure how this is apparently working (or if it is) but the NaN should never compare equal to itself. On earlier versions of C isnan was often a macro that expanded to this comparison. isnan is in the standard library since C++11 so IMO this ought to be used on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant