docs(effects): update examples to standalone api #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timdeschryver
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks for your work on this @AdrianRomanski
For next time, also try to add the issue number into the PR template (I've updated it now)
| @@ -229,31 +242,6 @@ It's recommended to inject all dependencies as effect function arguments for eas | |||
|
|
|||
| ## Registering Root Effects | |||
|
|
|||
| After you've written class-based or functional effects, you must register them so the effects start running. To register root-level effects, add the `EffectsModule.forRoot()` method with an array or sequence of effects classes and/or functional effects dictionaries to your `AppModule`. | |||
There was a problem hiding this comment.
Can you add a note about NgModules similar to https://github.com/sheikalthaf/platform/blob/6f926343e3f50e1d9a35c90b3c76c811d3fc9dbe/projects/ngrx.io/content/guide/router-store/index.md?plain=1#L30 please?
…ctors, add missing imports
|
@ timdeschryver i pushed first changes :) Tommorrow i will do the remaining |
|
@AdrianRomanski are you willing to address the remaining feedback? |
|
@timdeschryver yes, i will sit to this straight after the office |
timdeschryver
requested changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4468
What is the new behavior?
Does this PR introduce a breaking change?
Other information