Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncInterceptor cannot handle exeptions #52

Open
ladenedge opened this issue Nov 27, 2019 · 2 comments
Open

AsyncInterceptor cannot handle exeptions #52

ladenedge opened this issue Nov 27, 2019 · 2 comments

Comments

@ladenedge
Copy link
Contributor

AsyncInterceptor is awesome, but it cannot handle faulted tasks.

On first glance it looks like one could override AfterInvoke(IInvocation invocation, Task task) and check the IsFaulted property of the task, but the last ContinueWith() contains this code:

invocationClone.ReturnValue = t.Result;
this.AfterInvoke(invocationClone);
this.AfterInvoke(invocationClone, t);
return (TResult)invocationClone.ReturnValue;

Thus, AfterInvoke() is only called if task.Result does not throw—which it will if the task is faulted!

What I believe is needed is a check of t.IsFaulted before accessing t.Result and then calling the virtual methods appropriately.
ladenedge pushed a commit to ladenedge/Ninject.Extensions.Interception that referenced this issue Nov 27, 2019
@jaymillerverint
ninject#52 - Added check for faulted task in AsyncInterceptor and ass…
c802a27 
…ociated tests.
@ladenedge ladenedge mentioned this issue Nov 27, 2019
Merged
@ladenedge
Copy link
Contributor Author

Please see #53 for the PR that resolves this issue. Thank you!

ladenedge pushed a commit to ladenedge/Ninject.Extensions.Interception that referenced this issue Dec 5, 2019
@jaymillerverint
ninject#52 - The AsyncInterceptor now "pipelines" results, allowing f…
4a915ab 
…or multiple interceptors. Also full support for HandleExceptions and CompleteInvoke in both async and sync scenarios.
scott-xu pushed a commit that referenced this issue Feb 12, 2021
@ladenedge @jaymillerverint
Add check for faulted task in AsyncInterceptor (#53)
a267001 
* #52 - Added check for faulted task in AsyncInterceptor and associated tests.

* Reverted a C# 8 feature.

* #52 - The AsyncInterceptor now "pipelines" results, allowing for multiple interceptors.  Also full support for HandleExceptions and CompleteInvoke in both async and sync scenarios.

Co-authored-by: Jay Miller <[email protected]>
@iandawson
Copy link

Any chance of releasing the nuget package which includes this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ladenedge @iandawson