Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use .unwrap() #65

Open
L-as opened this issue Jun 30, 2023 · 1 comment
Open

Don't use .unwrap() #65

L-as opened this issue Jun 30, 2023 · 1 comment

Comments

@L-as
Copy link
Contributor

L-as commented Jun 30, 2023

All uses should be replaced by something that reports a useful error.
In many cases the panic should probably be turned into a Result::Err instead and passed back up.
This is especially problematic because panics don't contain any useful debugging information when compiled to WASM.
See rustwasm/wasm-bindgen#1289
@mitschabaude
Copy link
Collaborator

I agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitschabaude @L-as