-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace/imrpove regex parsing for extracting co-authors of pr_collaborated events #492
Comments
hii @rithviknishad i want to work on this issue i have understand that what is wrong with this but not to get that where should i make this chances , is there any documentation so the reference, is there any way you can help with this, |
https://docs.ohc.network/docs/leaderboard/gsoc-2024/refactor-scraper#3-parseeventsts leaderboard/scraper/src/github-scraper/parseEvents.ts Lines 53 to 55 in ad4cb04
|
One thing I've identified is that the current implementation only captures a single match for the regex pattern /Co-authored-by: (.+) <(.+)>/, which can be problematic if there are multiple Co-authored-by entries in the commit message. Additionally, any slight variations in the format (like additional spaces or different capitalizations) could result in missed matches. Proposed Fix: Adjust the regular expression or use a more robust method to handle multiple Co-authored-by entries. |
The core issue is, it's parsing authors incorrectly as mentioned in #492 (comment) Finding all co-authors, nice find, it can simply be done by using |
Yes, you’re correct that using Here’s why the loop is necessary:
So, while If you're open to it, I can go ahead and implement this fix! |
I have created a pull request #519 . Please Check and let me Know if i have made some mistake. |
hey @rithviknishad! waiting for review on #541. |
At times the pr_collaborated event yields incorrect co-author results
leaderboard/scraper/src/github-scraper/parseEvents.ts
Lines 53 to 55 in ad4cb04
The text was updated successfully, but these errors were encountered: