Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Define clear expectations for Triager role in contributor ladder #4338

Open
lelia opened this issue Sep 5, 2024 · 3 comments
Open
Labels
kind/enhancement New feature or request

Comments

@lelia
Copy link
Contributor

lelia commented Sep 5, 2024

Is your feature request related to a problem? Please describe.

Currently, the path for Scorecard Triagers is a bit vague and unstructured. The following excerpt from CONTRIBUTOR_LADDER.md describes the responsibilities as such:

- Read through issues and PRs
  - Answer questions when possible
  - Add relevant labels
  - Draw maintainers' attention (via `@mention`) if relevant
  - Close issue (as "completed" or "not planned") if necessary
- Help maintain project quality control via [code reviews] on PRs
  - Focus on code quality and correctness, including testing and factoring
  - May also review for more holistic issues, but not a requirement
- Be responsive to review requests
- May be assigned PRs to review if in area of expertise
- Assigned test bugs related to the project of expertise

There are a few issues with this:

  1. No real guidelines or process exists for issue backlog refinement / triaging. There have been prior community efforts to triage the issues in most need of refinement, and maintainers will comment on / address issues as they're able, but this often yields inconsistent results and duplicated efforts.
  2. It's difficult for triagers to know which maintainers are a) actively contributing to the codebase, b) have relevant expertise in a particular Scorecard domain, c) have direct knowledge of planned future work for Scorecard. The CODEOWNERS file references ossf/scorecard-maintainers, which corresponds to MAINTAINERS, but there's little else to go on besides using git blame or browsing PR / commit history to discern authorship.
  3. The default contributor ladder path assumes that the trajectory will always be triager -> contributor -> maintainer. For non-code contributors, there is little room to grow and contribute more meaningfully to Scorecard by way of technical documentation, product or project management, etc.

Describe the solution you'd like

  • An updated contributor ladder which adds more explicit clarity to the Triager responsibilities, including guidance or concrete examples for issue triaging / backlog refinement, and a better process for @mentioning specific Scorecard maintainers.
  • An expanded or alternate contributor ladder path to be created in direct support of non-code contributions.

Additional context
This was discussed at the Scorecard community meeting on 09/05/24.

cc: @hsutor

@lelia lelia added the kind/enhancement New feature or request label Sep 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

This issue has been marked stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Nov 5, 2024
@hsutor
Copy link

hsutor commented Nov 6, 2024

Perhaps the triager guidance could also be more specific on which labels to add in which scenarios. We could make a section that is about the different labels in the project and what they mean. Otherwise, "- Add relevant labels" is a bit vague.

@github-actions github-actions bot removed the Stale label Nov 7, 2024
@spencerschrock
Copy link
Member

Perhaps the triager guidance could also be more specific on which labels to add in which scenarios.

The biggest one to jump out at me from memory is the various check/Foo labels, and possibly kind/question if something is mislabelled as a bug/enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants