Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager-components]: <Datagrid> #13794

Open
1 task done
seven-amid opened this issue Oct 25, 2024 · 1 comment
Open
1 task done

[manager-components]: <Datagrid> #13794

seven-amid opened this issue Oct 25, 2024 · 1 comment

Comments

@seven-amid
Copy link
Contributor

seven-amid commented Oct 25, 2024

Have you already checked if a similar item is present on manager-components?

  • Yes, I have already checked the existing components/hooks/utils.

What do you expect from this request?

Component

Description

We have a use case in load balancer to display a popover on the data grid title. Currently, the title is typed as a string, but we need it to accept a JSX element as well to support this functionality. Could you please update it accordingly?
Here is an example of wanted behaviour
image

Where do you expect to use this?

load-balancer

Do you have mock-up?

No response

When do you expect this to be delivered?

No response

Additional Information

No response

@anooparveti
Copy link
Contributor

Instead of accepting the JSX element as input. We will make a change to accept tooltip and display it.

<Datagrid
       columns={[{ id: 'abc', cell: <span>Test</span>, label: 'test', tooltip: t('tooltip_content')}]}
       ...
/>

This helps in maintaining more uniformity with displaying label, sort option and tooltip across the apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants