Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Web executor fill action behavior change between 1.1.0 and 1.2.0 #793

Open
ArnaudLec opened this issue May 16, 2024 · 4 comments
Open

Comments

@ArnaudLec
Copy link

We are currently validating the impacts for migrating Venom to v1.2.0 and found a regression on the web executor when filling inputs which already contained values.

Before, with the v1.1.0, when filling a field which already contained a value, it was clearing the value before filling the input.

Now it concatenates the value and there's no option to clear the input beforehand.

Our use case is an option to duplicate a configuration in a screen and the form comes back already filled.

@ArnaudLec
Copy link
Author

@yesnault Hi, I suppose, this has been closed by mistake because of #803.
Can you reopen it since it's still a regression ?

@yesnault
Copy link
Member

Hi @ArnaudLec, can you provide a full reproducer please? We'll reopen this issue.

@ArnaudLec
Copy link
Author

I can't attach html or yaml files so since they are short, here they are.

Save this as input.html :

<!DOCTYPE html>
<html>
<body>
  <form>
    <input type="text" name="val" value="Initial_value" />
    <button type="submit">Submit</button>
  </form>
</body>
</html>

And here is the corresponding testsuite :

name: Input not emptied anymore on fill
vars:
  web:
    driver: chrome
    width: 1920
    height: 1080
    args:
    - 'browser-test'
    prefs:
      profile.default_content_settings.popups: 0
      profile.default_content_setting_values.notifications: 1
    timeout: 60
    debug: true
  url: 'file://{{.venom.testsuite.workdir}}/input.html'
testcases:
- name: reproducer
  steps:
  - type: web
    action:
      navigate:
        url: "{{.url}}"
  - type: web
    action:
      fill:
      - find: input[type="text"]
        text: "Some_other_value"
  - type: web
    action:
      click:
        find: button[type="submit"]
  - type: web
    action:
      click:
        find: input[type="text"]
    assertions:
    - result.url ShouldEqual "{{.url}}?val=Some_other_value"

@yesnault
Copy link
Member

Thank you @ArnaudLec , we'll check that

@yesnault yesnault reopened this Aug 14, 2024
@github-actions github-actions bot removed the Stale label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants