Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Badges to the META.json #48

Open
theory opened this issue Jun 6, 2015 · 5 comments
Open

Add Badges to the META.json #48

theory opened this issue Jun 6, 2015 · 5 comments

Comments

@theory
Copy link
Member

theory commented Jun 6, 2015

Add a section to the resources section of the meta spec to allow specification of badges. Perhaps we'd have a whitelist of badges to display on the site, such as those for Travis, GitHub, Coveralls, and badge.fury.io. It might look something like this:

"badges": {
    "travis": {
        "img": "https://travis-ci.org/theory/pgtap.png",
        "link": "https://travis-ci.org/theory/pgtap"
    },
    "coveralls": {
        "img": "https://coveralls.io/repos/theory/sqitch/badge.svg",
        "link": "https://coveralls.io/r/theory/sqitch"
    }
}
@theory theory added this to the v0.20 milestone Jun 6, 2015
@theory
Copy link
Member Author

theory commented Jun 7, 2015

Or perhaps:

"badges": [
    {
        "name": "travis",
        "img": "https://travis-ci.org/theory/pgtap.png",
        "link": "https://travis-ci.org/theory/pgtap"
    },
    {
        "name": "coveralls",
        "img": "https://coveralls.io/repos/theory/sqitch/badge.svg",
        "link": "https://coveralls.io/r/theory/sqitch"
    }
]

@decibel
Copy link

decibel commented Jun 10, 2015

Perhaps we shouldn't accept full URLs. We should already know that a travis badge is at travis-ci.org, for example. This way people couldn't just push random links up to the site.

@theory
Copy link
Member Author

theory commented Jun 10, 2015

My thought is to let them put in whatever they want, but the site will only display those from know domains.

@decibel
Copy link

decibel commented Jun 10, 2015 via email

@theory theory modified the milestones: v0.20, v0.17.0 Aug 31, 2015
@theory
Copy link
Member Author

theory commented Sep 1, 2015

How about this?

"badges": {
  "travis": "theory/pgtap",
  "coveralls": "theory/pgtap"
}

What other badges might people want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants