Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Callback Interface #9

Open
theory opened this issue Apr 23, 2011 · 3 comments
Open

Add Release Callback Interface #9

theory opened this issue Apr 23, 2011 · 3 comments
Assignees
Labels
Milestone

Comments

@theory
Copy link
Member

theory commented Apr 23, 2011

Right now, tweets are sent out on successful release from within the controller. There are a few problems with this, though:

  • The user can get an error on tweet failure, even though upload and release was successful
  • One might want to send out other notifications on successful upload (e.g., IRC, identi.ca, etc.)
  • One might want to do other things on successful download, such as execute a command-line utility (e.g, pgxn_api_sync).

So create an interface for adding callbacks on successful release, but where the user doesn't get an error if any callbacks fail. They should be configurable in the configuration file, and easy to implement. Perhaps use Plack middleware as a model.

@theory
Copy link
Member Author

theory commented May 14, 2011

Another suggestion from Hitoshi Harada:

  • Send an email on successful release. Perhaps to a mail list?

@umitanuki
Copy link

In terms of fail tolerant system, I'd suggest MQ. But for customizability of users I don't know which direction should go.

@theory theory modified the milestones: v0.20, v0.16 Aug 31, 2015
@theory theory self-assigned this Feb 5, 2023
@theory
Copy link
Member Author

theory commented Feb 5, 2023

I'm working on this now, since I need to rip out the Twitter support anyway. Just adding a trigger to the distributions table that passes the distribution meta JSON as a payload to pg_notify(), and implementing a library to consume various notifications and dispatch to various consumers, including Twitter and Mastodon for now. Will make it pretty straightforward to add new integrations in the future by writing a pretty simple Perl module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants