Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

campaign-exports: send one email per bulk export operation #1660

Open
henryk1229 opened this issue Aug 10, 2023 · 0 comments · May be fixed by #1661
Open

campaign-exports: send one email per bulk export operation #1660

henryk1229 opened this issue Aug 10, 2023 · 0 comments · May be fixed by #1661
Labels
improvement: enhancement ✨ Improvement to existing functionality platform: node 🔅 Related to Node backend

Comments

@henryk1229
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Support for exporting multiple campaigns at once was introduced by #1641 - but part of the desired behavior was punted in order to unblock merge. Currently, when admins export multiple campaigns they receive one email per campaign exported with links to the relevant urls. Instead, admins should receive one email per bulk operation, with links to each exported campaign's data.

Describe the solution you'd like
Currently, the export-multiple-campaigns wraps the export-campaign task, dispatching one task per campaignId included in the payload. The export-multiple-campaigns task should be refactored to:

  • dispatch individual jobs per campaign exported (but not send an email after the exports run)
  • collect the generated links to exported campaign data
  • send an email to the admin with the links for each campaign

Describe alternatives you've considered
graphile-worker has built-in support for batch jobs, but it's unclear if the use-case fits our needs. It would also likely mean that the multiple vs. single campaign export workflows would deviate significantly, which might lead to confusion or trouble down the line.

@henryk1229 henryk1229 added platform: node 🔅 Related to Node backend improvement: enhancement ✨ Improvement to existing functionality labels Aug 10, 2023
@henryk1229 henryk1229 self-assigned this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement: enhancement ✨ Improvement to existing functionality platform: node 🔅 Related to Node backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant