Epoch 2.0 Cookie Issue with name, email, website

[ronalfy]

Need to set the cookies for logged-out users.

[Vernal]

use wp_set_comment_cookies

[Shelob9]

I spoke with Ryan about this. wp_set_comment_cookies() isn't used by core because setting cookies isn't RESTful, which make sense. He recommended reverse engineering wp_set_comment_cookies() with javascript, which sucks, or going with out.

Reverse engineering it sucks and would mess with forward compatibility.

We could call the regular function ourselves. Would not take effect until next page load, but I think that's OK, like this I think:

    add_action( 'rest_insert_comment', function( $comment ){
        if( isset( $_GET[ 'epoch' ] ) ){
            wp_set_comment_cookies( $comment, get_user_by( 'ID', get_current_user_id() ) );
        }
    });

Let's get some judgment of @Vernal here.

[Vernal]

So this is to say that the comment would post, but the cookie would not be set until the user revisits/reloads the site @Shelob9 ?

[Shelob9]

That is correct.

On Sep 26, 2016 2:33 PM, "Jason Lemieux" [email protected] wrote:

So this is to say that the comment would post, but the cookie would not be
set until the user revisits/reloads the site @Shelob9
https://github.com/Shelob9 ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#207 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB5uR1IX5EpJAFpJ9Of26wulcXjl75XFks5quA_wgaJpZM4IpOIA
.

[Shelob9]

I think.

On Sep 26, 2016 3:03 PM, wrote:

That is correct.

On Sep 26, 2016 2:33 PM, "Jason Lemieux" [email protected] wrote:

So this is to say that the comment would post, but the cookie would not
be set until the user revisits/reloads the site @Shelob9
https://github.com/Shelob9 ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#207 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB5uR1IX5EpJAFpJ9Of26wulcXjl75XFks5quA_wgaJpZM4IpOIA
.

[Vernal]

I think that's totally fine.

[Vernal]

hey @lukecav and @shawnhooper can I get one of you guys to focus on this issue and we'll see if it helps resolve #218, #181, and #211? Let's start with this one. The solution could very well be right here..

[lukecav]

@Vernal Just looking now.