Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd.socket mounting inside container - security concern / best practice deviation? #682

Open
huornlmj opened this issue Dec 7, 2023 · 5 comments
Labels
bug Something isn't working keep-alive

Comments

@huornlmj
Copy link

huornlmj commented Dec 7, 2023

Describe the bug
Not a bug, not a feature request, not a security vulnerability announcement with a fix I can provide, but security related so this is the closest fit available

Additional context
During threat modelling of the Akri installation with my cluster I observed the containerd.sock file is mounted inside the container. Mounting the containerisation socket file inside a container is a deviation from security best practices, and so I wanted to check with the community what protections or mitigations are in place to balance the issue? In a nutshell, do you know this is happening and are you OK with it?

@huornlmj huornlmj added the bug Something isn't working label Dec 7, 2023
@github-project-automation github-project-automation bot moved this to Triage needed in Akri Roadmap Dec 7, 2023
@diconico07
Copy link
Contributor

The containerd socket is mounted inside the agent's container to allow for slot reconciliation, the need for this socket is specified in the documentation as well : https://docs.akri.sh/user-guide/cluster-setup#configure-crictl

In a nutshell, as the DevicePlugin system doesn't call the agent when de-allocating the resource, we have to get the information about really used resources from the CRI endpoint.

There are future developments that will close this gap, namely the DRA (Dynamic Resource Allocation) mode that is currently planned will replace the DevicePlugin system with DRA that do notify the driver on de-allocation of resources.

Please note that DRA will not be on by default until it is out of alpha stage on all supported kubernetes versions.

@kate-goldenring
Copy link
Contributor

This may point out that Akri cannot achieve 1.0 until it has moved to DRA due to this security concern.

@kate-goldenring
Copy link
Contributor

@diconico07 is investigating a new approach in #684 which does not mount the containerd.socket

@kate-goldenring kate-goldenring moved this from Triage needed to Investigating in Akri Roadmap Jan 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions github-actions bot added the stale label Apr 9, 2024
@huornlmj
Copy link
Author

Not stale, still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep-alive
Projects
Status: Investigating
Development

No branches or pull requests

3 participants