Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom informers from InstaScale #47

Open
anishasthana opened this issue Mar 30, 2023 · 0 comments
Open

Remove custom informers from InstaScale #47

anishasthana opened this issue Mar 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@anishasthana
Copy link
Member

We have custom informers set up for InstaScale to watch events on appwrappers. As far as I can tell, the informer logic isn't doing anything special -- we should be able to just rely on the default reconcilation loop. Using the inbuilt controller-runtime for for the runtime should suffice. Refer to https://github.com/opendatahub-io/odh-model-controller/blob/main/controllers/inferenceservice_controller.go#L93 for a simple example.

This will reduce the complexity of our code

https://github.com/project-codeflare/instascale/blob/main/controllers/appwrapper_controller.go#L135-L148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant