Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated pvsystem.sapm_spectral_loss not removed #2243

Open
RDaxini opened this issue Oct 8, 2024 · 1 comment · May be fixed by #2244
Open

Deprecated pvsystem.sapm_spectral_loss not removed #2243

RDaxini opened this issue Oct 8, 2024 · 1 comment · May be fixed by #2244
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Oct 8, 2024

Describe the bug
pvsystem.sapm_spectral_loss was deprecated since v10.0 but I could not find any PRs to remove it in a future version (12.0?)

To Reproduce
Steps to reproduce the behavior:
See the read the docs page
and the tests

Expected behavior
Removed in v11.0

Versions:

  • pvlib.__version__: 11.2

Additional context
I am not super familiar with deprecations so please correct me if I have misunderstood something here or even missed an existing PR for this...

@RDaxini RDaxini linked a pull request Oct 8, 2024 that will close this issue
8 tasks
@kandersolar kandersolar added this to the v0.12.0 milestone Oct 9, 2024
@kandersolar
Copy link
Member

Yes, removing functions is done in .0 releases, so this will wait until 0.12.0 at the earliest. It's okay to leave #2244 open in the meantime, but opening PRs "early" like that means you may have to resolve some merge conflicts between now and then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants