Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the highly-outdated dependencies that doesn't provide content #3682

Open
huoyaoyuan opened this issue Nov 23, 2024 · 0 comments
Open

Comments

@huoyaoyuan
Copy link

Problem

A lot of System.* depdendencies used by Realm are for legacy .NET Standard 1.x and .NET Core 1.x world. They do nothing for current platforms and will regress build performance because of building large NuGet graph. Occasionally, they produces security alerts that gets warned by toolchains. Although they are not meaningful for current platforms, it takes additional effort to mitigate the warnings. For example, System.Net.WebSockets.Client 4.3.2 brought System.Net.Security 4.3.0 which has warnings, causing Realm adding a direct dependency to System.Net.Security 4.3.2, both of which are unnecessary.

Solution

Remove these dependencies from all target frameworks (netstandard2.0, net6.0 and net 8.0):

  • System.Dynamic.Runtime
  • System.Net.Security
  • System.Net.WebSockets.Client

Remove these dependencies from .NET Core (net6.0 and net8.0), via conditional dependency in project file:

  • System.Buffers
  • System.Memory
  • System.Runtime.CompilerServices.Unsafe

Alternatives

No response

How important is this improvement for you?

Fairly niche but nice to have anyway

Feature would mainly be used with

-- select --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant