Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In VulkanNodeHelpers, Old newCommandBuffer allocation #534

Open
PowerOfNames opened this issue Jun 6, 2023 · 1 comment
Open

In VulkanNodeHelpers, Old newCommandBuffer allocation #534

PowerOfNames opened this issue Jun 6, 2023 · 1 comment
Labels
confirmed Issue is reproducible enhancement Issue or PR discusses an enhancement vulkan Concerns only the Vulkan backend

Comments

@PowerOfNames
Copy link
Contributor

PowerOfNames commented Jun 6, 2023

In VulkanNodeHelpers.kt, function UpdateInstanceBuffers, near the end of the function, the commandBuffer-call for copying a buffer -> it used the old calloc instead of a stackPush.

@PowerOfNames PowerOfNames added enhancement Issue or PR discusses an enhancement vulkan Concerns only the Vulkan backend labels Jun 6, 2023
@skalarproduktraum skalarproduktraum added the confirmed Issue is reproducible label Jun 14, 2023
@skalarproduktraum
Copy link
Member

Confirmed! And @PowerOfNames, did you know you can just copy file + line numbers from Github? They'll show up like this:

val copyRegion = VkBufferCopy.calloc(1)
.size(instanceBufferSize * 1L)
VK10.vkCmdCopyBuffer(this,
stagingBuffer.vulkanBuffer,
instanceBuffer.vulkanBuffer,
copyRegion)
copyRegion.free()

Just browse to the file, click on the first line, shift-click on the last line you'd like to select, then copy the URL 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue is reproducible enhancement Issue or PR discusses an enhancement vulkan Concerns only the Vulkan backend
Projects
None yet
Development

No branches or pull requests

2 participants