Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check README attributions #11415

Open
2 tasks done
madmatt opened this issue Oct 3, 2024 · 4 comments
Open
2 tasks done

Check README attributions #11415

madmatt opened this issue Oct 3, 2024 · 4 comments

Comments

@madmatt
Copy link
Member

madmatt commented Oct 3, 2024

Module version(s) affected

4.x, 5.x, 6.x

Description

The README has an Attributions section in it, which hasn't been updated for quite some time. Either we should remove this, or update it to reference what we actually use. I don't think we use the icon set anymore, perhaps since v2 days, though I could be wrong?

How to reproduce

Just view the README file 😉

Possible Solution

No response

Additional Context

Closest other issue is a comment from Dan on #6756 back in 2017 but this was missed as the PR was already merged and closed.

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@GuySartorelli
Copy link
Member

Just view the README file

But I don't know which icons it's referring to. :p

@madmatt
Copy link
Member Author

madmatt commented Oct 3, 2024

I mean it links here - not sure we've used any of these icons in the past decade? :p
https://p.yusukekamiyamane.com/

@GuySartorelli
Copy link
Member

Looks like blue-folder-horizontal in silverstripe/cms (yes I know, that's not this repo) is used from that website.

I'm not sure where the images in silverstripe/admin (again not this repo) came from, but some of them share a similar style to that website so may have originated from there. Many of them are bundled in spritesheets so I can't search for them by name like I could the folder.

So - yes, probably remove from this repo's readme, but looks like we need to add it to at least the cms readme and maybe the admin readme.

@madmatt
Copy link
Member Author

madmatt commented Oct 3, 2024

Huh - okay well if it's still relevant then we should keep it. I can't say I've seen any of those icons in a long time heh. The curse of long-term support strikes again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants