Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changestop event not fired if mouse enters iframe #254

Open
notrealdev opened this issue Nov 1, 2020 · 6 comments
Open

changestop event not fired if mouse enters iframe #254

notrealdev opened this issue Nov 1, 2020 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed PR Welcome A Pull request would be awesome

Comments

@notrealdev
Copy link

When click and hold then move the pointer to red area, changestop event not fire.
Can you check it?

My image:
Imgur

My video:
https://youtu.be/xqpt3gJ2gaQ

@simonwep
Copy link
Owner

simonwep commented Nov 2, 2020

Please stick to the Issue Template. Create a JSFiddle and describe what you've done as detailed as possible and break your issue down to a minimum. This will help me to resolve it as fast as possible.

@simonwep simonwep closed this as completed Nov 2, 2020
@notrealdev
Copy link
Author

Yes, i have create issue on jsbin here:
https://jsbin.com/gapilib/edit?html,output

In this case, left content for color picker, right content for iframe map.

Issue:

  • Show the picker
  • When select color, click hold then move the pointer to iframe area then unclick, changestop event not fire. You can see change event still fire when hover mouse on the left content.

@notrealdev
Copy link
Author

Hi @simonwep can you check it?

@simonwep
Copy link
Owner

simonwep commented Nov 5, 2020

Not sure if I can fix that in case the iframe intercepts and prevents propagation of the mouseup event. I'll take a look at it on the weekend.

@simonwep simonwep reopened this Nov 5, 2020
@simonwep simonwep added the bug Something isn't working label Nov 5, 2020
@simonwep simonwep changed the title Pickr and wordpress customizer changestop event not fired if mouse enters iframe Nov 5, 2020
@simonwep
Copy link
Owner

Looks like this is rather difficult to fix according to this StackOverflow thread 😕

@simonwep simonwep added help wanted Extra attention is needed PR Welcome A Pull request would be awesome labels Nov 10, 2020
@christianceb
Copy link

christianceb commented Nov 11, 2020

I have a PoC on detecting dragend over iframes but it involves applying the CSS property pointer-events: none on iframes while dragging. I'm not sure how much of a valid solution it is by using CSS to bypass JS limitations, but I can tell you that because the current standards of HTMLIFrameElement, it will be very difficult or impossible to make a fix purely on JS. Let me know what you think about it and I'll throw in a PR

@simonwep simonwep removed their assignment Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed PR Welcome A Pull request would be awesome
Projects
None yet
Development

No branches or pull requests

3 participants