Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil>>#ifTrue: causes UnsupportedSpecializationException #227

Open
daumayr opened this issue Feb 21, 2018 · 10 comments
Open

Nil>>#ifTrue: causes UnsupportedSpecializationException #227

daumayr opened this issue Feb 21, 2018 · 10 comments
Labels
bug Fixes an issue, incorrect implementation good first issue Are you trying to have a good at SOMns? Start here! help wanted Would be great if you could help out here.

Comments

@daumayr
Copy link
Contributor

daumayr commented Feb 21, 2018

Probably should not expose implementation details to users, unsupported operations should lead to dnu or meaningful SOM exceptions.

Stacktrace:

com.oracle.truffle.api.dsl.UnsupportedSpecializationException: Unexpected values provided for IfInlinedLiteralNode@79caea7f: [a Nil], [SObjectWithoutFields]
	at som.interpreter.nodes.specialized.IfInlinedLiteralNode.evaluateCondition(IfInlinedLiteralNode.java:40)
	at som.interpreter.nodes.specialized.IfInlinedLiteralNode.executeGeneric(IfInlinedLiteralNode.java:46)
        ...
@smarr
Copy link
Owner

smarr commented Feb 21, 2018

Yes, it shouldn't. Seems like a simple getting-started issue, would keep it open, except if it annoys you.

@smarr smarr added bug Fixes an issue, incorrect implementation help wanted Would be great if you could help out here. good first issue Are you trying to have a good at SOMns? Start here! labels Feb 21, 2018
@daumayr
Copy link
Contributor Author

daumayr commented Feb 21, 2018

that was my intention, there are similar issues all around, so a lot to do for beginners

@CortezDeuce
Copy link

I'm new here and wouldn't mind taking a look at it and giving it a shot. I haven't even gotten to my profile yet, but here is a little bit about me. I've been in school in some shape or form, for coding,since 2000. There were periods throughout that I have not coded, but am re-focusing my attention there. I have coded for a govt contractor for a time period of 3 years using c++,vb, and vbscript, but I have experience with many languages including java, java script, and web languages. I'd like to become an active contributor on the network and need to start somewhere :) Let me know what you think.
Thanks.
Cort

@smarr
Copy link
Owner

smarr commented Mar 5, 2018

Hi @CortezDeuce:

Sure, if you want to dig in, you might want to start having a look at http://somns.readthedocs.io/en/dev/
It describes some basic steps on how to setup things.

I'd start to approach this issue by writing a few test cases as part of https://github.com/smarr/SOMns/blob/dev/core-lib/TestSuite/LanguageTests.ns
Great would be to test for the working and the not working conditions around all relevant ifTrue:, ifFalse: methods. Since there are some optimizations for the cases that explicit blocks (lambdas) are given, we probably also should check for those explicitly.

Please don't hesitate to ask questions.
Some of the terminology is somewhat Smalltalk specific and not necessarily generally known.

@CortezDeuce
Copy link

@smarr Thanks!
I'm working on getting everything setup per the documentation at the link(s) you've provided. Looks as if I needed ubuntu to use SOMs properly, so I'm getting that taken care of, and re-installing eclipse,soms plugin, etc. If I run into any issues that have me stuck I'll reach out to you. I'm sure there will be some questions from my end. Thanks again and speak with you soon

@smarr
Copy link
Owner

smarr commented Mar 5, 2018

@CortezDeuce Ubuntu is not strictly required. I am using macOS. And there have been people using Fedora and other Linux variants.
It just happens to be that we haven't had anyone using something that needed specific other instructions.

The only platform currently not supported is Windows.

@CortezDeuce
Copy link

@smarr This may be silly, but running into an issue and hoping you could help me get past it. Note: using a VM with Ubuntu 32bit. Getting stuck on this line( yes "n" | ./build.sh ) It's returningthe error below. Am I unable to perform this on a 32bit system? Thanks!

%% Make sure git submodules are up-to-date

%% JAVA_HOME=
%% Build JVMCI-enabled JVM

unknown or unsupported architecture: os=linux, machine=i686

@smarr
Copy link
Owner

smarr commented Mar 6, 2018

@CortezDeuce If I remember correctly, Graal does not support 32-bit, 64bit would be needed. However, for this particular issue, you might not even need Graal (SOMns can run without by passing the -G flag).

@CortezDeuce
Copy link

@smarr ok, that's what I was figuring, but was hesitant to move on, skipping a step. Thanks, I'll continue on with the steps listed.

@smarr
Copy link
Owner

smarr commented Mar 11, 2018

@CortezDeuce once #232 is merged, things should be simpler, and documentation improved hopefully, too

@smarr smarr changed the title Nil>>#ifTrue: causes UnsopportedSpecializationException Nil>>#ifTrue: causes UnsupportedSpecializationException Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes an issue, incorrect implementation good first issue Are you trying to have a good at SOMns? Start here! help wanted Would be great if you could help out here.
Projects
None yet
Development

No branches or pull requests

3 participants