Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name resolution in getSetterSend seems wrong #239

Open
smarr opened this issue Mar 19, 2018 · 0 comments
Open

Name resolution in getSetterSend seems wrong #239

smarr opened this issue Mar 19, 2018 · 0 comments
Labels
bug Fixes an issue, incorrect implementation good first issue Are you trying to have a good at SOMns? Start here! language-design Not everything is in the spec, sometimes, we need to decide what's best.
Milestone
later

Comments

@smarr
Copy link
Owner

smarr commented Mar 19, 2018

getSetterSend checks different kind of names depth first instead of breadth first.

This seems wrong, because an local variable in a more inner scope is not found before some argument in an outer scope:

See to do introduced in:
https://github.com/smarr/SOMns/pull/233/files#diff-6753c8d394a8952d61bc05fe26679bfaR585

Think this is a good first issue to get started with the parser and related code.

First step to work on this should be to produce a test case.
@smarr smarr added bug Fixes an issue, incorrect implementation language-design Not everything is in the spec, sometimes, we need to decide what's best. good first issue Are you trying to have a good at SOMns? Start here! labels Mar 19, 2018
@smarr smarr added this to the later milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes an issue, incorrect implementation good first issue Are you trying to have a good at SOMns? Start here! language-design Not everything is in the spec, sometimes, we need to decide what's best.
Projects
None yet
Milestone
later
Development

No branches or pull requests
1 participant
@smarr